Bug 31891

Summary: Off-by-one error in index validation for drawElements and drawArrays
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Major CC: brettw, cmarrin, commit-queue, oliver, petersont, rlp
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2009-11-25 16:11:24 PST
There is an off-by-one error in the index validation introduced in https://bugs.webkit.org/show_bug.cgi?id=31239 which is one of the reasons some demos no longer work. The computation of the available elements in the bound array buffers does not take into account the fact that for the last element, the number of bytes touched is only that of the data itself, not including the stride.
Attachments
Patch (6.43 KB, patch)
2009-11-25 16:15 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2009-11-25 16:15:46 PST
Created attachment 43875 [details] Patch
Oliver Hunt
Comment 2 2009-11-25 16:25:51 PST
Comment on attachment 43875 [details] Patch r=me
WebKit Commit Bot
Comment 3 2009-11-25 16:44:49 PST
Comment on attachment 43875 [details] Patch Clearing flags on attachment: 43875 Committed r51400: <http://trac.webkit.org/changeset/51400>
WebKit Commit Bot
Comment 4 2009-11-25 16:44:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.