Summary: | Support reflections on composited layers | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cmarrin, eric, gfesteves | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2009-11-25 12:21:02 PST
Created attachment 43871 [details]
Patch: part 1
Comment on attachment 43871 [details] Patch: part 1 > + if (m_structuralLayer || m_contentsLayer || childLayers.size() > 0) { In WebKit style we'd normally omit that "> 0". > + updateLayerPosition(); > + updateLayerSize(); > + updateAnchorPoint(); > + updateTransform(); > + updateChildrenTransform(); > > + updateSublayerList(); > + updateOpacityOnLayer(); This is kind of funny -- and it's repeated more than once. Shouldn't this also be calling updateLayerNames? r=me Comment on attachment 43871 [details] Patch: part 1 This patch committed: http://trac.webkit.org/changeset/52029 Created attachment 44716 [details]
Patch
Created attachment 44718 [details]
Followup patch for reflected canvas3d
Stashing this patch here; will clean up and submit with changelog once the previous patch is committed.
I'm unclear as to if this mega-patch is still supposed to be up for review? Yes, it is. I'll fix up canvas3d in a separate patch. *** Bug 31899 has been marked as a duplicate of this bug. *** It's been another 3 weeks, looking through the pending-commit queue and just wanted to check back on the state of this patch. The patch still needs review. I had some interest from Sam and Dan. Comment on attachment 43871 [details]
Patch: part 1
Clearing Darin Adler's r+ on this obsolete patch so this doesn't show up in the pending-commit list.
Created attachment 46706 [details]
Patch
Attachment 46706 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/189495 Comment on attachment 46706 [details]
Patch
r=me w/ a few cooments made in person
|