Bug 31870

Summary: Add OutputCaputure class for sharing capture_output between unit tests
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests. none

Eric Seidel (no email)
Reported 2009-11-25 07:11:57 PST
Add OutputCaputure class for sharing capture_output between unit tests
Attachments
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests. (7.04 KB, patch)
2009-11-25 07:23 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-11-25 07:23:21 PST
Created attachment 43841 [details] Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
Adam Barth
Comment 2 2009-11-25 07:28:22 PST
Comment on attachment 43841 [details] Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests. Looks good. I had sketched this out as a base class, but compositing is better.
WebKit Commit Bot
Comment 3 2009-11-25 07:46:13 PST
Comment on attachment 43841 [details] Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests. Clearing flags on attachment: 43841 Committed r51381: <http://trac.webkit.org/changeset/51381>
WebKit Commit Bot
Comment 4 2009-11-25 07:46:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.