Bug 31870

Summary: Add OutputCaputure class for sharing capture_output between unit tests
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests. none

Description Eric Seidel (no email) 2009-11-25 07:11:57 PST
Add OutputCaputure class for sharing capture_output between unit tests
Comment 1 Eric Seidel (no email) 2009-11-25 07:23:21 PST
Created attachment 43841 [details]
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
Comment 2 Adam Barth 2009-11-25 07:28:22 PST
Comment on attachment 43841 [details]
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.

Looks good.  I had sketched this out as a base class, but compositing is better.
Comment 3 WebKit Commit Bot 2009-11-25 07:46:13 PST
Comment on attachment 43841 [details]
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.

Clearing flags on attachment: 43841

Committed r51381: <http://trac.webkit.org/changeset/51381>
Comment 4 WebKit Commit Bot 2009-11-25 07:46:17 PST
All reviewed patches have been landed.  Closing bug.