Summary: | Update pywebsocket to 0.4.2 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuzo Fujishima <yuzo> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 31604 | ||||||||||
Attachments: |
|
Description
Yuzo Fujishima
2009-11-25 01:05:33 PST
Created attachment 43830 [details]
Update pywebsocket to 0.4.2
Comment on attachment 43830 [details]
Update pywebsocket to 0.4.2
LGTM too, but it look slike the new files are missing. Was this uploaded by 'bugzilla-tool post-diff' or post-commits? Those should both use --binary and correctly include new files.
Created attachment 43883 [details]
Update pywebsocket to 0.4.2
Created attachment 43884 [details]
Update pywebsocket to 0.4.2
Hi, thank you for the review. The file permission for the .py files were 755 for the first patch. That might have caused the commit issue? I've changed the permission to 644, which is the same as that of the files already in the repository. (I used bugzilla-tool post-commits. bugzilla-tool help post-commits/post-diff doesn't show --binary option and bugzilla-tool actually rejected the option for me. So I haven't used it.) Yuzo Comment on attachment 43884 [details]
Update pywebsocket to 0.4.2
I think I was simply confused. I'm not sure there was any issue w/ the first patch.
Comment on attachment 43884 [details] Update pywebsocket to 0.4.2 Clearing flags on attachment: 43884 Committed r51406: <http://trac.webkit.org/changeset/51406> All reviewed patches have been landed. Closing bug. |