Bug 31861

Summary:

Update pywebsocket to 0.4.2

Product:

WebKit

Reporter:

Yuzo Fujishima <yuzo>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

31604

Attachments:

Description	Flags
Update pywebsocket to 0.4.2	none
Update pywebsocket to 0.4.2	none
Update pywebsocket to 0.4.2	none

Yuzo Fujishima

Reported 2009-11-25 01:05:33 PST

Update pywebsocket to 0.4.2 (http://code.google.com/p/pywebsocket/). In the new version a few bugs have been fixed, including one for https://bugs.webkit.org/show_bug.cgi?id=31603 (already fixed in the WebKit copy). Also, the new version has better logging, which is needed for https://bugs.webkit.org/show_bug.cgi?id=31604

Attachments
Update pywebsocket to 0.4.2 (20.26 KB, patch) 2009-11-25 01:07 PST, Yuzo Fujishima	no flags	Details Formatted Diff Diff
Update pywebsocket to 0.4.2 (17.34 KB, patch) 2009-11-25 18:04 PST, Yuzo Fujishima	no flags	Details Formatted Diff Diff
Update pywebsocket to 0.4.2 (16.43 KB, patch) 2009-11-25 18:05 PST, Yuzo Fujishima	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yuzo Fujishima

Comment 1 2009-11-25 01:07:20 PST

Created attachment 43830 [details] Update pywebsocket to 0.4.2

Eric Seidel (no email)

Comment 2 2009-11-25 07:49:18 PST

Comment on attachment 43830 [details] Update pywebsocket to 0.4.2 LGTM too, but it look slike the new files are missing. Was this uploaded by 'bugzilla-tool post-diff' or post-commits? Those should both use --binary and correctly include new files.

Yuzo Fujishima

Comment 3 2009-11-25 18:04:57 PST

Created attachment 43883 [details] Update pywebsocket to 0.4.2

Yuzo Fujishima

Comment 4 2009-11-25 18:05:47 PST

Created attachment 43884 [details] Update pywebsocket to 0.4.2

Yuzo Fujishima

Comment 5 2009-11-25 18:11:19 PST

Hi, thank you for the review. The file permission for the .py files were 755 for the first patch. That might have caused the commit issue? I've changed the permission to 644, which is the same as that of the files already in the repository. (I used bugzilla-tool post-commits. bugzilla-tool help post-commits/post-diff doesn't show --binary option and bugzilla-tool actually rejected the option for me. So I haven't used it.) Yuzo

Eric Seidel (no email)

Comment 6 2009-11-25 22:04:03 PST

Comment on attachment 43884 [details] Update pywebsocket to 0.4.2 I think I was simply confused. I'm not sure there was any issue w/ the first patch.

WebKit Commit Bot

Comment 7 2009-11-25 22:16:18 PST

Comment on attachment 43884 [details] Update pywebsocket to 0.4.2 Clearing flags on attachment: 43884 Committed r51406: <http://trac.webkit.org/changeset/51406>

WebKit Commit Bot

Comment 8 2009-11-25 22:16:24 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.