Bug 31851

Summary:

[Qt] QWebInspector unusable on certain window managers

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, hausmann, jturcotte

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Call setVisible from within the closeEvent	hausmann: review+
Backport for 4.6	none

Holger Freyther

Reported 2009-11-24 14:50:40 PST

Created attachment 43811 [details] Call setVisible from within the closeEvent QWebInspector::hideEvent will call setVisible on the InspectorController disabling/resetting certain views. E.g. on ion3 the hide event is called when switching windows... so when going back to the QWebView every information is gone.. The code could be changed to call it from within the closeEvent. This should work for many usecases and in the worse case data of the InspectorController is held in memory a bit longer. For binary compability reasons I'm leaving an empty ::hideEvent in the code...

Attachments
Call setVisible from within the closeEvent (2.62 KB, patch) 2009-11-24 14:50 PST, Holger Freyther	hausmann: review+	Details Formatted Diff Diff
Backport for 4.6 (2.40 KB, patch) 2009-12-15 02:43 PST, Holger Freyther	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-11-30 12:38:21 PST

style-queue successfully ran check-webkit-style on attachment 43811 [details] without any errors

Simon Hausmann

Comment 2 2009-12-04 15:21:36 PST

Comment on attachment 43811 [details] Call setVisible from within the closeEvent I think the patch is correct. Holger, do you think it's worth including in Qt 4.6.1? (in which case we need to cherry-pick a version that uses ::event() instead) Jocelyn, any thoughts? :)

Holger Freyther

Comment 3 2009-12-04 21:56:49 PST

(In reply to comment #2) > (From update of attachment 43811 [details]) > I think the patch is correct. > > Holger, do you think it's worth including in Qt 4.6.1? (in which case we need > to cherry-pick a version that uses ::event() instead) Yes, without this the web inspector is completely useless on ion3... > > Jocelyn, any thoughts? :)

Jocelyn Turcotte

Comment 4 2009-12-06 05:06:57 PST

yep, I agree!

Holger Freyther

Comment 5 2009-12-15 01:31:30 PST

Landed in r52144.

Holger Freyther

Comment 6 2009-12-15 02:43:34 PST

Created attachment 44856 [details] Backport for 4.6 backport for the 4.6 branch

Simon Hausmann

Comment 7 2009-12-15 03:03:27 PST

(In reply to comment #6) > Created an attachment (id=44856) [details] > Backport for 4.6 > > backport for the 4.6 branch Thanks! Pushed into qtwebkit-4.6 as f1c562daf7b4d784cb9f386e47fc132e0843321f

Note You need to log in before you can comment on or make changes to this bug.