Bug 31849

Summary:

[Qt] Implement initializeMaximumHTTPConnectionCountPerHost

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, markus, mjs, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Provide an implementation	none
Provide a Qt specific implementation	hausmann: review+, commit-queue: commit-queue-

Holger Freyther

Reported 2009-11-24 14:37:40 PST

Created attachment 43807 [details] Provide an implementation Provide a Qt implementation for the above method. The current limit inside the Qt framework is six connections per host (and three in the pipeline).

Attachments
Provide an implementation (2.92 KB, patch) 2009-11-24 14:37 PST, Holger Freyther	no flags	Details Formatted Diff Diff
Provide a Qt specific implementation (3.79 KB, patch) 2009-12-03 03:36 PST, Holger Freyther	hausmann: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-11-25 07:52:56 PST

Why "must this match"? I agree it probably should, I'm just confused by the comment.

Holger Freyther

Comment 2 2009-11-27 21:00:51 PST

You are right. There is no must. I will post an updated patch.

Holger Freyther

Comment 3 2009-12-03 03:36:02 PST

Created attachment 44225 [details] Provide a Qt specific implementation Slight improvement of the comment. I probably need to do some grammar and spelling fixes in one more round.

WebKit Review Bot

Comment 4 2009-12-03 03:37:47 PST

style-queue ran check-webkit-style on attachment 44225 [details] without any errors.

Simon Hausmann

Comment 5 2009-12-04 15:08:06 PST

Comment on attachment 44225 [details] Provide a Qt specific implementation r=me

WebKit Commit Bot

Comment 6 2009-12-13 01:32:24 PST

Comment on attachment 44225 [details] Provide a Qt specific implementation Rejecting patch 44225 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Simon Hausmann', '--force']" exit_code: 1 Last 500 characters of output: m/network/qt/ResourceRequestQt.cpp | 16 +++++++++++++++- 3 files changed, 34 insertions(+), 2 deletions(-) ------------------------------------------------------------------- patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/network/ResourceRequestBase.cpp Hunk #1 FAILED at 378. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/network/ResourceRequestBase.cpp.rej patching file WebCore/platform/network/qt/ResourceRequestQt.cpp

Holger Freyther

Comment 7 2009-12-13 18:43:57 PST

I waited for Dimitri to respond to my response. If Dimitri thinks there should be more work done we can reopen the bug again, for now closing is the most easy way to make it drop out of the review queue.

Holger Freyther

Comment 8 2009-12-13 18:56:29 PST

Okay, this was on the wrong bug. I will land this change in a second.. so there is no need to reopen it.

Holger Freyther

Comment 9 2009-12-13 19:11:33 PST

Landed in r52079.

Markus Goetz

Comment 10 2010-04-06 03:26:31 PDT

This negatively interfers with HTTP pipelining in QNetworkAccessManager. I've sent a mail to the qtwebkit dev list.

Note You need to log in before you can comment on or make changes to this bug.