Bug 31849

Summary: [Qt] Implement initializeMaximumHTTPConnectionCountPerHost
Product: WebKit Reporter: Holger Freyther <zecke>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, markus, mjs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Provide an implementation
none
Provide a Qt specific implementation hausmann: review+, commit-queue: commit-queue-

Description Holger Freyther 2009-11-24 14:37:40 PST
Created attachment 43807 [details]
Provide an implementation

Provide a Qt implementation for the above method. The current limit inside the Qt framework is six connections per host (and three in the pipeline).
Comment 1 Eric Seidel (no email) 2009-11-25 07:52:56 PST
Why "must this match"? I agree it probably should, I'm just confused by the comment.
Comment 2 Holger Freyther 2009-11-27 21:00:51 PST
You are right. There is no must. I will post an updated patch.
Comment 3 Holger Freyther 2009-12-03 03:36:02 PST
Created attachment 44225 [details]
Provide a Qt specific implementation

Slight improvement of the comment. I probably need to do some grammar and spelling fixes in one more round.
Comment 4 WebKit Review Bot 2009-12-03 03:37:47 PST
style-queue ran check-webkit-style on attachment 44225 [details] without any errors.
Comment 5 Simon Hausmann 2009-12-04 15:08:06 PST
Comment on attachment 44225 [details]
Provide a Qt specific implementation

r=me
Comment 6 WebKit Commit Bot 2009-12-13 01:32:24 PST
Comment on attachment 44225 [details]
Provide a Qt specific implementation

Rejecting patch 44225 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Simon Hausmann', '--force']" exit_code: 1
Last 500 characters of output:
m/network/qt/ResourceRequestQt.cpp |   16 +++++++++++++++-
 3 files changed, 34 insertions(+), 2 deletions(-)


-------------------------------------------------------------------
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/platform/network/ResourceRequestBase.cpp
Hunk #1 FAILED at 378.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/network/ResourceRequestBase.cpp.rej
patching file WebCore/platform/network/qt/ResourceRequestQt.cpp
Comment 7 Holger Freyther 2009-12-13 18:43:57 PST
I waited for Dimitri to respond to my response. If Dimitri thinks there should be more work done we can reopen the bug again, for now closing is the most easy way to make it drop out of the review queue.
Comment 8 Holger Freyther 2009-12-13 18:56:29 PST
Okay, this was on the wrong bug. I will land this change in a second.. so there is no need to reopen it.
Comment 9 Holger Freyther 2009-12-13 19:11:33 PST
Landed in r52079.
Comment 10 Markus Goetz 2010-04-06 03:26:31 PDT
This negatively interfers with HTTP pipelining in QNetworkAccessManager. I've sent a mail to the qtwebkit dev list.