Bug 31848

Summary:

Remove uses of mainThreadCurrentWorld, and of currentWorld using a globalData.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

WebCore JavaScript

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
The patch	ggaren: review+

Gavin Barraclough

Reported 2009-11-24 14:35:54 PST

These methods get the world from the global data rather than from an execstate. If the current world is always read from an exec state then it can be read from the global object, and world entry can become automagical, rather than being explicitly set by an EnterDOMWrapperWorld.

Attachments
The patch (20.52 KB, patch) 2009-11-24 14:37 PST, Gavin Barraclough	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2009-11-24 14:37:41 PST

Created attachment 43808 [details] The patch

Geoffrey Garen

Comment 2 2009-11-24 14:58:28 PST

Comment on attachment 43808 [details] The patch hasCachedDOMObjectWrapper can just call contains, rather than get.

Gavin Barraclough

Comment 3 2009-11-24 15:43:32 PST

Sending WebCore/ChangeLog Sending WebCore/bindings/js/JSCSSRuleCustom.cpp Sending WebCore/bindings/js/JSCSSValueCustom.cpp Sending WebCore/bindings/js/JSDOMBinding.cpp Sending WebCore/bindings/js/JSDOMBinding.h Sending WebCore/bindings/js/JSDOMWindowCustom.cpp Sending WebCore/bindings/js/JSDocumentCustom.cpp Sending WebCore/bindings/js/JSElementCustom.cpp Sending WebCore/bindings/js/JSEventCustom.cpp Sending WebCore/bindings/js/JSHTMLCollectionCustom.cpp Sending WebCore/bindings/js/JSImageDataCustom.cpp Sending WebCore/bindings/js/JSNodeCustom.cpp Sending WebCore/bindings/js/JSSVGPathSegCustom.cpp Sending WebCore/bindings/js/JSStyleSheetCustom.cpp Sending WebCore/xml/XMLHttpRequest.cpp Transmitting file data ............... Committed revision 51363.

Note You need to log in before you can comment on or make changes to this bug.