Bug 31840

Summary:

bisect-builds broke after r50080

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.4

URL:

http://trac.webkit.org/changeset/50080

Bug Depends on:

30572

Bug Blocks:

Attachments:

Description	Flags
Patch v1	mitz: review+

Description David Kilzer (:ddkilzer) 2009-11-24 10:50:12 PST

* SUMMARY
The changes to the bisect-builds script in r50080 were incorrect.  Patch forthcoming.

Comment 1 David Kilzer (:ddkilzer) 2009-11-24 10:52:00 PST

Created attachment 43789 [details]
Patch v1

Comment 2 David Kilzer (:ddkilzer) 2009-11-24 11:51:44 PST

Committed r51346: <http://trac.webkit.org/changeset/51346>

Comment 3 Csaba Osztrogonác 2009-11-25 13:27:04 PST

(In reply to comment #2)
> Committed r51346: <http://trac.webkit.org/changeset/51346>
Thanks for fix. Unfortunately I wasn't able to try it on Mac before landing. But I have no idea why it was incorrect, I frequently use similar exec statements. Strange ...

Comment 4 David Kilzer (:ddkilzer) 2009-11-25 14:13:55 PST

(In reply to comment #3)
> (In reply to comment #2)
> > Committed r51346: <http://trac.webkit.org/changeset/51346>
> Thanks for fix. Unfortunately I wasn't able to try it on Mac before landing.
> But I have no idea why it was incorrect, I frequently use similar exec
> statements. Strange ...

It's because exec() is different from the backtick operator (``).  exec() will run the program and then exit the Perl script immediately.  The backtick operator (``) is more like a system() call where it runs the command, then returns to the Perl script to continue executing it.