Summary: | [Android] The select elements do not reflect the actual choice the user makes. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrei Popescu <andreip> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | android-webkit-unforking, benm | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Other | ||||||
Attachments: |
|
Description
Andrei Popescu
2009-11-24 06:57:19 PST
Created attachment 43846 [details]
Handle the drawing of ListBoxes in Android code. Also fix exisiting style issues.
Comment on attachment 43846 [details] Handle the drawing of ListBoxes in Android code. Also fix exisiting style issues. Thanks for cleaning up the old code! r=me, except: > bool RenderThemeAndroid::paintTextArea(RenderObject* obj, const RenderObject::PaintInfo& info, const IntRect& rect) > { > - if (obj->isMenuList()) > - return paintCombo(obj, info, rect); > + if (obj->isListBox()) { > + paintCombo(obj, info, rect); Can this be just an early return? (In reply to comment #2) > (From update of attachment 43846 [details]) > Thanks for cleaning up the old code! > > r=me, except: > > > bool RenderThemeAndroid::paintTextArea(RenderObject* obj, const RenderObject::PaintInfo& info, const IntRect& rect) > > { > > - if (obj->isMenuList()) > > - return paintCombo(obj, info, rect); > > + if (obj->isListBox()) { > > + paintCombo(obj, info, rect); > > Can this be just an early return? I can make this change on landing. |