Bug 31810

Summary:

[Android] Android port requires platform-specific implementation of initializeMaximumHTTPConnectionCountPerHost

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Steve Block <steveblock>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, android-webkit-unforking, ap, beidson, commit-queue, eric, fishd, mjs, phanna, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Attachments:

Description	Flags
Patch 1 for Bug 31810	none

Steve Block

Reported 2009-11-23 10:45:33 PST

Android port requires platform-specific implementation of initializeMaximumHTTPConnectionCountPerHost.

Attachments
Patch 1 for Bug 31810 (3.57 KB, patch) 2009-11-23 10:57 PST, Steve Block	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2009-11-23 10:57:12 PST

Created attachment 43720 [details] Patch 1 for Bug 31810

Eric Seidel (no email)

Comment 2 2009-11-23 20:05:44 PST

I thought the point of this default was less about what the loader was capable of, and more about "being a good web citizen" or something. Donno. I'm not an expert here.

Steve Block

Comment 3 2009-11-25 09:38:28 PST

(In reply to comment #2) > I thought the point of this default was less about what the loader was capable > of, and more about "being a good web citizen" or something. Donno. I'm not an > expert here. The comment in loader.cpp for maxRequestsInFlightPerHost, and the comment in ResourceRequestBase.cpp for initializeMaximumHTTPConnectionCountPerHost both seem to suggest that the objective of this limit is to match the capability of the network layer. Can you point me to an expert who can confirm the intended use?

Eric Seidel (no email)

Comment 4 2009-11-25 09:42:04 PST

Maciej or Bradey should know.

Adam Barth

Comment 5 2009-11-30 12:36:37 PST

style-queue successfully ran check-webkit-style on attachment 43720 [details] without any errors

Darin Fisher (:fishd, Google)

Comment 6 2009-12-11 10:06:08 PST

Comment on attachment 43720 [details] Patch 1 for Bug 31810 This patch is fine. Given such a high limit on connection counts per host, you might also consider disabling the REQUEST_MANAGEMENT_ENABLED define in loader.cpp.

WebKit Commit Bot

Comment 7 2009-12-11 10:24:50 PST

Comment on attachment 43720 [details] Patch 1 for Bug 31810 Clearing flags on attachment: 43720 Committed r52005: <http://trac.webkit.org/changeset/52005>

WebKit Commit Bot

Comment 8 2009-12-11 10:24:55 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.