Bug 31808

Summary: createShader() needs better param checking
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: WebGLAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch including test eric: review+

Description Chris Marrin 2009-11-23 09:52:57 PST 
it will accept any non-FRAGMENT_SHADER value as GL_VERTEX_SHADER
Comment 1 Chris Marrin 2009-11-24 10:05:40 PST 
Created attachment 43779 [details]
Patch including test
Comment 2 Eric Seidel (no email) 2009-11-24 10:42:44 PST 
Comment on attachment 43779 [details]
Patch including test

Looks good, but maybe NOT_SUPPORTED_ERR would be better?
Comment 3 Chris Marrin 2009-11-24 17:57:35 PST 
We need to revisit the whole exception model of WebGL. For now we have been using SYNTAX_ERR for bad params, so I'll leave it at that for now.
Comment 4 Chris Marrin 2009-11-24 19:13:42 PST 
Landed in http://trac.webkit.org/changeset/51370