Bug 31807

Summary: [Android] Android port lacks platform-specific WTF thread functions
Product: WebKit Reporter: Steve Block <steveblock>
Component: JavaScriptCoreAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, ap, commit-queue, dimich, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch 1 for Bug 31807 none

Steve Block
Reported 2009-11-23 08:44:17 PST
Android port lacks platform-specific WTF thread functions - initializeMainThreadPlatform() - scheduleDispatchFunctionsOnMainThread()
Attachments
Patch 1 for Bug 31807 (2.76 KB, patch)
2009-11-23 08:54 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2009-11-23 08:54:37 PST
Created attachment 43718 [details] Patch 1 for Bug 31807
Dmitry Titov
Comment 2 2009-11-23 12:06:33 PST
Comment on attachment 43718 [details] Patch 1 for Bug 31807 r=me. > +using namespace android; This seems not needed and can be removed on landing...
Steve Block
Comment 3 2009-11-23 14:38:38 PST
> > +using namespace android; > This seems not needed and can be removed on landing... JavaSharedClient will be added to WebKit/android and uses namespace android.
WebKit Commit Bot
Comment 4 2009-11-23 14:55:30 PST
Comment on attachment 43718 [details] Patch 1 for Bug 31807 Clearing flags on attachment: 43718 Committed r51323: <http://trac.webkit.org/changeset/51323>
WebKit Commit Bot
Comment 5 2009-11-23 14:55:35 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2009-11-23 15:52:16 PST
Should we delete Android-specific code from ThreadingPthreads.cpp now? I can't wait to get rid of layering violations in runThreadWithRegistration().
Steve Block
Comment 7 2009-11-25 09:48:34 PST
(In reply to comment #6) > Should we delete Android-specific code from ThreadingPthreads.cpp now? I can't > wait to get rid of layering violations in runThreadWithRegistration(). No, I'm afraid this is still required.
Note You need to log in before you can comment on or make changes to this bug.