Bug 31794

Summary: [Qt] Mac Plugins : Get Input Events to work in QGV
Product: WebKit Reporter: Girish Ramakrishnan <girish>
Component: Plug-insAssignee: Girish Ramakrishnan <girish>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, aroben, eric, hausmann, kdecker, vestbo, yongjun.zhang, zecke
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 31183    
Bug Blocks:    
Attachments:
Description Flags
Plugin events (ideal)
none
Plugin events (reality)
none
Pass mouse position relative to the fake window
none
Pass activeWindow() to make Flash process mouse move events
hausmann: review+
Make mouse over work without using active window zecke: review+

Girish Ramakrishnan
Reported 2009-11-22 21:07:27 PST
Rendering was fixed in 31183. Events are still not getting delivered correctly.
Attachments
Plugin events (ideal) (973 bytes, patch)
2009-11-23 06:08 PST, Girish Ramakrishnan 		no flags
DetailsFormatted DiffDiff
Plugin events (reality) (2.58 KB, patch)
2009-11-23 06:09 PST, Girish Ramakrishnan 		no flags
DetailsFormatted DiffDiff
Pass mouse position relative to the fake window (2.14 KB, patch)
2009-11-25 04:58 PST, Girish Ramakrishnan 		no flags
DetailsFormatted DiffDiff
Pass activeWindow() to make Flash process mouse move events (4.81 KB, patch)
2009-11-25 05:01 PST, Girish Ramakrishnan 		hausmann: review+
DetailsFormatted DiffDiff
Make mouse over work without using active window (3.28 KB, patch)
2009-11-26 02:33 PST, Girish Ramakrishnan 		zecke: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Girish Ramakrishnan
Comment 1 2009-11-23 06:08:28 PST
Created attachment 43709 [details] Plugin events (ideal) This is how plugin events should work ideally.
Girish Ramakrishnan
Comment 2 2009-11-23 06:09:36 PST
Created attachment 43710 [details] Plugin events (reality) Flash requires the window that we pass to be the active window. So, an extremely ugly patch to please flash.
Girish Ramakrishnan
Comment 3 2009-11-25 04:58:22 PST
Created attachment 43836 [details] Pass mouse position relative to the fake window
Girish Ramakrishnan
Comment 4 2009-11-25 05:01:11 PST
Created attachment 43837 [details] Pass activeWindow() to make Flash process mouse move events I did not add a plugin quirk (PluginQuirkRequiresActiveWindowForInputEvents) because there is a bug in the Mac port - PluginPackage::determineQuirks is never called. Also, the plugin quirk seems to complicate the code a bit. So, what about leaving it out for now?
Simon Hausmann
Comment 5 2009-11-25 05:49:00 PST
Comment on attachment 43837 [details] Pass activeWindow() to make Flash process mouse move events r=me, but a quirk would be nice to have in the future.
Girish Ramakrishnan
Comment 6 2009-11-26 02:33:13 PST
Created attachment 43911 [details] Make mouse over work without using active window Ok, I have figured out a way to make events work without using QApplication::activeWindow().
Girish Ramakrishnan
Comment 7 2009-11-26 05:05:46 PST
Landed in r51412
Girish Ramakrishnan
Comment 8 2009-11-26 05:06:41 PST
Comment on attachment 43911 [details] Make mouse over work without using active window Clear r?
Holger Freyther
Comment 9 2009-11-26 05:19:22 PST
Comment on attachment 43911 [details] Make mouse over work without using active window Just for the record... I r=me'd on irc..
Note You need to log in before you can comment on or make changes to this bug.