Bug 31792

Summary:

Include "config.h" to meet Coding Style Guidelines

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, kenneth

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed patch	none

Description Laszlo Gombos 2009-11-22 18:41:37 PST

Found a few places where config.h is not included as it is described in the style guide - http://webkit.org/coding/coding-style.html.

Note that there are a few places (e.g. API tests for WebKit public API, *AllInOne*.cpp etc) where config.h is obviously not needed. This patch does not add config.h to those files.

Comment 1 Laszlo Gombos 2009-11-22 18:44:34 PST

Created attachment 43691 [details]
proposed patch

Comment 2 Alexey Proskuryakov 2009-11-22 23:46:24 PST

Comment on attachment 43691 [details]
proposed patch

That's a lot of files without config.h!

I'm worried about changes to some Windows files - seems that definitions in WebKitDLL.h might be necessary to compile subsequent headers - e.g. WebScriptObject.h. Did you verify that the Windows port builds with these changes?

Comment 3 Laszlo Gombos 2009-11-23 14:26:05 PST

Alexey, thanks for looking into this.

I just verified that the (Safari) Windows port builds with these changes. It looks to me that quite many .cpp files under WebKit/win have the same include order (e.g. WebSecurityOrigin.cpp).

Comment 4 Kenneth Rohde Christiansen 2009-11-23 14:32:46 PST

Then I'm all for this patch! Let's hope things go well, so please watch the bot after you commit.

Comment 5 Laszlo Gombos 2009-11-23 20:35:33 PST

Landed as http://trac.webkit.org/changeset/51336.