| Summary: | Web Inspector: Introduce sidebar background on timeline panel in order to prevent it from flickering on scroll. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bweinstein, joepeck, rik, timothy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Pavel Feldman
2009-11-22 11:53:48 PST
Created attachment 43685 [details]
[PATCH] proposed fix
Comment on attachment 43685 [details] [PATCH] proposed fix > - this._refreshTimeout = setTimeout(this._refresh.bind(this), 100); > + this._refreshTimeout = setTimeout(this._refresh.bind(this), immediate ? 0 : 100); A 0 delay timeout isn't immediate, it will be 10ms in Safari. That matter? (In reply to comment #2) > (From update of attachment 43685 [details]) > > > - this._refreshTimeout = setTimeout(this._refresh.bind(this), 100); > > + this._refreshTimeout = setTimeout(this._refresh.bind(this), immediate ? 0 : 100); > > A 0 delay timeout isn't immediate, it will be 10ms in Safari. > > That matter? Not really, I just don't want to wait extra 100ms on scroll since I know i need to redraw and there is no need in coalescing. As a result, 100ms coalescing is only there for window resize (to make it real smooth) and for adding entries (for obvious reasons). Note that I can't invoke refresh on scroller synchronously since it would break the scroller smoothness. Anyway, I think 10ms is good. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js M WebCore/inspector/front-end/inspector.css Committed r51297 |