Bug 31767

Summary:

commit-queue fails to run with "permissions error" due to bad bugzilla-tool path

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+

Eric Seidel (no email)

Reported 2009-11-21 07:01:55 PST

commit-queue fails to run with "permissions error" due to bad bugzilla-tool path When we moved the queue commands into queues.py, an important __file__ definition came with, and now the commit-queue is trying to exec queues.py instead of bugzilla-tool when launching land-attachment for the commit-queue. I couldn't think of a useful unit test for this. What we really want to test is that BugzillaToo.path() points to an executable script. However we don't have any way to unit test BugzillaTool itself yet.

Attachments
Patch (3.72 KB, patch) 2009-11-21 07:05 PST, Eric Seidel (no email)	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-11-21 07:05:13 PST

Created attachment 43647 [details] Patch

Adam Barth

Comment 2 2009-11-21 07:28:16 PST

Comment on attachment 43647 [details] Patch Yep. My bad

Eric Seidel (no email)

Comment 3 2009-11-21 07:50:38 PST

Committed r51283: <http://trac.webkit.org/changeset/51283>

Note You need to log in before you can comment on or make changes to this bug.