Bug 31747

Summary: Chromium Linux: Limit the stroke width and mitre limit
Product: WebKit Reporter: Adam Langley <agl>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch
none
patch dimich: review+

Adam Langley
Reported 2009-11-20 14:39:15 PST
Chromium Linux: Limit the stroke width and mitre limit that we'll pass into Skia to avoid overflowing Skia's uint16_t glyph widths.
Attachments
patch (2.18 KB, patch)
2009-11-20 14:40 PST, Adam Langley 		no flags
DetailsFormatted DiffDiff
patch (2.35 KB, patch)
2009-11-23 11:32 PST, Adam Langley 		dimich: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2009-11-20 14:40:54 PST
Created attachment 43614 [details] patch
Dmitry Titov
Comment 2 2009-11-20 22:16:05 PST
It'd be useful to document in the bug and/or comment why did you use 512 and 256. If this is a random choice, that's fine but it's useful to put it in writing so the next person reading the code does not have to guess if there is some magic meaning behind those. Or if there is magic meaning, it's even more useful to document :-)
Adam Langley
Comment 3 2009-11-23 11:32:48 PST
Created attachment 43723 [details] patch Good point about the comment. Have added one.
Dmitry Titov
Comment 4 2009-11-23 11:57:52 PST
Comment on attachment 43723 [details] patch r=me
Adam Langley
Comment 5 2009-11-23 14:13:53 PST
r51319
Note You need to log in before you can comment on or make changes to this bug.