Bug 31740
| Summary: | New Bug Attachment + Patch checkbox does not show contribution terms | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | William Siegrist <wsiegrist> |
| Component: | WebKit Website | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | ASSIGNED | ||
| Severity: | Normal | CC: | ap, ddkilzer |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | https://bugs.webkit.org/enter_bug.cgi?product=WebKit | ||
William Siegrist
When you attach a patch to a bug, some contribution terms are supposed to appear. The terms need to appear on the page when the Patch checkbox is checked. It works on the attachment page at <https://bugs.webkit.org/attachment.cgi?bugid=3564&action=enter>. It does not work when attaching during the initial filing of a bug <https://bugs.webkit.org/enter_bug.cgi?product=WebKit>.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Rowe (bdash)
It seems like we have a similar issue with other methods of submitting patches (eg, via bugzilla-tool).
Alexey Proskuryakov
One can't reasonably upload patches when creating a bug, because bug number is needed to write a ChangeLog.
David Kilzer (:ddkilzer)
(In reply to comment #1)
> It seems like we have a similar issue with other methods of submitting patches
> (eg, via bugzilla-tool).
I filed Bug 31757 for bugzilla-tool.
(In reply to comment #2)
> One can't reasonably upload patches when creating a bug, because bug number is
> needed to write a ChangeLog.
I've wanted to use a place-holder for the bug number in the ChangeLog, then make the various tools (bugzilla-tool, etc.) smart enough to do the replacement when the patch was applied. People could still post an initial patch for review without a ChangeLog if they just wanted feedback as well.
William Siegrist
(In reply to comment #2)
> One can't reasonably upload patches when creating a bug, because bug number is
> needed to write a ChangeLog.
The terms govern submission of code to the WebKit project in general. So even if there is no way the project would accept the submission, there should still be terms on the submission page.
Ideally, the terms should be shown to anyone, using any method or tool, for anything that is intended to possibly land in the repository. But this bug is obviously just asking to cover the bugzilla form(s).
I suppose another option is to disable the patch attachment functionality in the new bug form if the project really wants to discourage that.
Alexey Proskuryakov
> I suppose another option is to disable the patch attachment functionality in
> the new bug form if the project really wants to discourage that.
Yes, that's precisely what I've been talking about. Given David's comment above, this may not be the best option.