Summary: | Web Inspector: Console Scope Bar should be on top of console when Console is a Panel | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Weinstein <bweinstein> | ||||||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Brian Weinstein <bweinstein> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Created attachment 43605 [details]
Screenshot 2
Screenshot 1 looks good, but Screenshot 2 does not. I think we should leave things as is for drawer version of console. I wonder what happens to animation then... Created attachment 43606 [details]
[PATCH] Fix
Comment on attachment 43606 [details]
[PATCH] Fix
We should not have the scope bar on top in drawer mode. It is hwere it is to save vertical space. I agree, it should be on top in panel mode though.
Created attachment 44575 [details]
Scope Bar On Bottom
Created attachment 44576 [details]
Scope Bar On Top
Created attachment 44577 [details]
[PATCH] Fix
Screenshots are with this patch applied.
style-queue ran check-webkit-style on attachment 44577 [details] without any errors.
Comment on attachment 44577 [details] [PATCH] Fix > + // Update styles, and give coneole-messages a top margin so it doesn't overwrite the scope bar. coneole-messages -> console-messages > + scopeBar.addStyleClass("console-filter-top"); > + document.getElementById("console-messages").style.marginTop = "23px"; xenon usually wants numbers to be a part of css (In reply to comment #9) > > + scopeBar.addStyleClass("console-filter-top"); > > + document.getElementById("console-messages").style.marginTop = "23px"; > > xenon usually wants numbers to be a part of css Yes this should be done by adding/removing a class name. Landed in r51952. |
Created attachment 43604 [details] Screenshot 1 Console Scope Bar should be on top of console to match other scope bars.