[GTK] DRT release event does not create the state correctly

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alejandro G. Castro]

The release events we synthesize in the DRT do not consider the state of the mouse, it is more correct to add the same state we add to the motion events. Apparently this is not causing any problem though.

[Alejandro G. Castro]

Created attachment 43572 [details]
Proposed patch, adds state info to release events

[Xan Lopez]

Comment on attachment 43572 [details]
Proposed patch, adds state info to release events

LGTM.

[WebKit Commit Bot]

Comment on attachment 43572 [details]
Proposed patch, adds state info to release events

Rejecting patch 43572 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--quiet', '43572']" exit_code: 1
Last 500 characters of output:
ingsequence.py", line 49, in run
    self.test()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 113, in test
    LandingSequence.test(self)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in test
    WebKitScripts.run_webkit_tests(launch_safari=not options.non_interactive, fail_fast=options.non_interactive, quiet=options.quiet, port=port)
NameError: global name 'WebKitScripts' is not defined

[Xan Lopez]

Comment on attachment 43572 [details]
Proposed patch, adds state info to release events

Let's try again...

[WebKit Commit Bot]

Comment on attachment 43572 [details]
Proposed patch, adds state info to release events

Clearing flags on attachment: 43572

Committed r51239: <http://trac.webkit.org/changeset/51239>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.