Bug 31700

Summary:

Web Inspector: isMac should be in one central location + Cached

Product:

WebKit

Reporter:

Brian Weinstein <bweinstein>

Component:

Web Inspector (Deprecated)

Assignee:

Brian Weinstein <bweinstein>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

31699

Bug Blocks:

Attachments:

Description	Flags
[PATCH] Fix	timothy: review-, bweinstein: commit-queue-
[PATCH] Use function instead of getter	timothy: review+, bweinstein: commit-queue-

Brian Weinstein

Reported 2009-11-19 19:11:52 PST

We have the same isMac code in multiple places throughout the code base. This should be refactored into a WebInspector.isMac, where that value can be cached, for the same reasons as webkit.org/b/31699. The refactoring would put the call to indexOf in one place, and we could cache the result.

Attachments
[PATCH] Fix (6.09 KB, patch) 2009-11-20 11:03 PST, Brian Weinstein	timothy: review- bweinstein: commit-queue-	Details Formatted Diff Diff
[PATCH] Use function instead of getter (6.20 KB, patch) 2009-11-20 11:45 PST, Brian Weinstein	timothy: review+ bweinstein: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brian Weinstein

Comment 1 2009-11-20 11:03:57 PST

Created attachment 43597 [details] [PATCH] Fix

Timothy Hatcher

Comment 2 2009-11-20 11:24:25 PST

Comment on attachment 43597 [details] [PATCH] Fix WebInspector.isMac should be a function, since it asks a question with it's name. Otherwise r+.

Brian Weinstein

Comment 3 2009-11-20 11:45:42 PST

Created attachment 43600 [details] [PATCH] Use function instead of getter

Brian Weinstein

Comment 4 2009-11-20 11:52:13 PST

Landed in r51250.

Note You need to log in before you can comment on or make changes to this bug.