Bug 316674
| Summary: | [ews-build] Refactor GenerateS3URL build step to call generateS3URL directly instead of via subprocess | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | New Bugs | Assignee: | Aakash Jain <aakash_jain> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Aakash Jain
GenerateS3URL was implemented as a MasterShellCommand that spawned python3 to invoke ../Shared/generate-s3-url, then re-parsed the generated URL out of the subprocess's stdout via a regex log observer. Both halves of that dance are unnecessary: the helper is already a Python module living next to the buildbot master, and the master process already has boto3 loaded.
Switch GenerateS3URL to inherit from buildstep.BuildStep and call generate_s3_url.generateS3URL() directly.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/179127972>
Aakash Jain
Pull request: https://github.com/WebKit/WebKit/pull/66776
EWS
Committed 315213@main (02dbc28ba78a): <https://commits.webkit.org/315213@main>
Reviewed commits have been landed. Closing PR #66776 and removing active labels.