Bug 31662

Summary: Don't run websocket tests when run-webkit-tests --no-http
Product: WebKit Reporter: Fumitoshi Ukai <ukai>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Ignore websocket tests when --no-http is specified. eric: review+

Fumitoshi Ukai
Reported 2009-11-19 00:11:30 PST
If run-webkit-tests --no-http, it should also disable websocket tests. cf. https://bugs.webkit.org/show_bug.cgi?id=31425 file:// documents should not be able to open WebSocket connections
Attachments
Ignore websocket tests when --no-http is specified. (821 bytes, patch)
2009-11-19 00:16 PST, Fumitoshi Ukai 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1 2009-11-19 00:16:11 PST
Created attachment 43491 [details] Ignore websocket tests when --no-http is specified.
Eric Seidel (no email)
Comment 2 2009-11-19 01:05:37 PST
Comment on attachment 43491 [details] Ignore websocket tests when --no-http is specified. LGTM.
Fumitoshi Ukai
Comment 3 2009-11-19 02:42:49 PST
Committed r51180: <http://trac.webkit.org/changeset/51180>
Alexey Proskuryakov
Comment 4 2009-11-19 09:49:30 PST
If we make the http option affect websocket tests (which is not necessarily the right thing to do IMO), then we should update run-webkit-tests help output: --[no-]http Run (or do not run) http tests (default: run)
Fumitoshi Ukai
Comment 5 2009-11-19 18:49:20 PST
(In reply to comment #4) > If we make the http option affect websocket tests (which is not necessarily the > right thing to do IMO), then we should update run-webkit-tests help output: > > --[no-]http Run (or do not run) http tests (default: run) Sorry. is it ok to update help output only, or better to add new flag for -[no-]websocket, instead of ignoring websocket by --no-http?
Note You need to log in before you can comment on or make changes to this bug.