Summary: | Don't run websocket tests when run-webkit-tests --no-http | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fumitoshi Ukai <ukai> | ||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Fumitoshi Ukai
2009-11-19 00:11:30 PST
Created attachment 43491 [details]
Ignore websocket tests when --no-http is specified.
Comment on attachment 43491 [details]
Ignore websocket tests when --no-http is specified.
LGTM.
Committed r51180: <http://trac.webkit.org/changeset/51180> If we make the http option affect websocket tests (which is not necessarily the right thing to do IMO), then we should update run-webkit-tests help output: --[no-]http Run (or do not run) http tests (default: run) (In reply to comment #4) > If we make the http option affect websocket tests (which is not necessarily the > right thing to do IMO), then we should update run-webkit-tests help output: > > --[no-]http Run (or do not run) http tests (default: run) Sorry. is it ok to update help output only, or better to add new flag for -[no-]websocket, instead of ignoring websocket by --no-http? |