Bug 31661

Summary: Remove HAVE(FLOAT_H) guard
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Description Laszlo Gombos 2009-11-18 22:50:28 PST 
HAVE(FLOAT_H) is meant to guard <float.h> includes. As of now the number of _unguarded_ <float.h> includes is 13; there is only 2 locations where float.h is guarded.

Based on these numbers it seems clear that neither JavaScriptCore nor WebCore would not build without float.h available.  All build would have to define HAVE(FLOAT_H), which is not the case today - and this sometimes leads to build inconsistencies (e.g. http://trac.webkit.org/changeset/51170).

I would proposed to remove the HAVE(FLOAT_H) - as this seems to be a hard dependency for all WebKit components.

Patch will follow.
Comment 1 Laszlo Gombos 2009-11-19 06:51:46 PST 
Created attachment 43498 [details]
proposed patch
Comment 2 WebKit Commit Bot 2009-11-19 11:54:57 PST 
Comment on attachment 43498 [details]
proposed patch

Clearing flags on attachment: 43498

Committed r51197: <http://trac.webkit.org/changeset/51197>
Comment 3 WebKit Commit Bot 2009-11-19 11:55:03 PST 
All reviewed patches have been landed.  Closing bug.