Bug 31656 – -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Oliver Hunt]

Drag images should not include overflow decorations from nodes that are not children

[Oliver Hunt]

Created attachment 43484 [details]
Patch

Comment on attachment 43484 [details]
Patch

> +    if (hasOverflowClip() && style()->visibility() == VISIBLE && (phase == PaintPhaseBlockBackground || phase == PaintPhaseChildBlockBackground)) {
> +        if (!paintInfo.paintingRoot || isDescendantOf(paintInfo.paintingRoot))
> +            layer()->paintOverflowControls(paintInfo.context, tx, ty, paintInfo.rect);
> +    }

Can’t use use shouldPaintWithinRoot? You are never supposed to be a proper descendant of the painting root.

You should just add the test to the first if’s condition instead of nesting like that.

It would be good to have a manual test case for this. I don’t think it necessarily has to be checked in, but at least attach it to the bug, if possible, for future reference.

r- because I think you don’t need to call isDescendantOf().

[Oliver Hunt]

Created attachment 43516 [details]
Patch

[Dave Hyatt]

Comment on attachment 43516 [details]
Patch

r=me

[Oliver Hunt]

Committed r51205