Bug 31655

Summary:

Normalize ' and " in bugzilla-tool

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2009-11-18 17:57:22 PST

Style ftw

Comment 1 Adam Barth 2009-11-18 17:58:23 PST

Created attachment 43475 [details]
Patch

Comment 2 Eric Seidel (no email) 2009-11-18 18:06:20 PST

Personally I prefer ' over ".  Although in either case we should be consistent.  We should see if the python style guide has guidance on this issue.

Comment 3 Eric Seidel (no email) 2009-11-18 18:17:05 PST

Adam recommends that we just pick one and go with it.  I'm not sure I care enough either way.  He suggests that whichever we pick that we pretend the other style doesn't exist at all. Meaning:

"foo \"bar\" baz" always instead of some sort of exception to allow 'foo "bar" baz'

Comment 4 Eric Seidel (no email) 2009-11-18 18:18:23 PST

Comment on attachment 43475 [details]
Patch

LGTM.  Sad to see my little ' go, but I'm glad these are consistent.

Comment 5 WebKit Commit Bot 2009-11-18 22:19:10 PST

Comment on attachment 43475 [details]
Patch

Clearing flags on attachment: 43475

Committed r51176: <http://trac.webkit.org/changeset/51176>

Comment 6 WebKit Commit Bot 2009-11-18 22:19:16 PST

All reviewed patches have been landed.  Closing bug.