Bug 31652

Summary: ASSERT thrown when a high value is used for roman numerals in lists
Product: WebKit Reporter: Rahul Kuchhal <kuchhal>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
potential fix for assert
eric: review-
patch with updated layout test none

Description Rahul Kuchhal 2009-11-18 16:17:25 PST 
WebKit throws ASSERT for this html:
<html> 
<body> 
<ol start="3888" type="i"> 
<li>Foo </li> 
</ol> 
</body> 
</html>

Posting one potential fix and a layout test soon.
Comment 1 Rahul Kuchhal 2009-11-18 16:21:57 PST 
Created attachment 43470 [details]
potential fix for assert
Comment 2 Eric Seidel (no email) 2009-11-19 01:08:02 PST 
Comment on attachment 43470 [details]
potential fix for assert

This should be a dumpAsText() test since it is just testing for a crash.

The test should say something like:

PASS: this test did not crash, bug 31652

for the output.
Comment 3 Rahul Kuchhal 2009-11-19 08:52:13 PST 
Created attachment 43507 [details]
patch with updated layout test
Comment 4 WebKit Commit Bot 2009-11-19 12:25:28 PST 
Comment on attachment 43507 [details]
patch with updated layout test

Clearing flags on attachment: 43507

Committed r51201: <http://trac.webkit.org/changeset/51201>
Comment 5 WebKit Commit Bot 2009-11-19 12:25:33 PST 
All reviewed patches have been landed.  Closing bug.