Bug 31648

Summary: [Chromium] Remove dependencies to dummy pthreads headers
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebKit Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch fishd: review+

Description Nate Chapin 2009-11-18 14:52:28 PST 
Currently, in order to build JavaScriptCore/wtf/, the Chromium port depends on a couple of dummy headers (pthread.h and sched.h) that live in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/build/ .   These dependencies are in fact not necessary, as they are located in wtf's tcmalloc files (which Chromium doesn't use).

Ergo, update JavaScriptCore.gyp to exclude wtf/TC*, and update WebKit/chromium/DEPS to not include webkit/build/ from chromium's svn repo.
Comment 1 Nate Chapin 2009-11-18 14:57:52 PST 
Created attachment 43465 [details]
patch
Comment 2 Darin Fisher (:fishd, Google) 2009-11-18 15:08:34 PST 
Comment on attachment 43465 [details]
patch

> Index: WebKit/chromium/ChangeLog
...
> +        Remove Chromium port's dependency on some dummy pthreads header
> +        files that live in the Chromium repository.

nit: please add a bug link here
Comment 3 Nate Chapin 2009-11-18 16:00:12 PST 
http://trac.webkit.org/changeset/51144