Bug 31616

Summary: [Chromium] Some minor cleanup in the Chromium WebKit API
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: WebKit APIAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch dimich: review+

Darin Fisher (:fishd, Google)
Reported 2009-11-17 22:43:26 PST
[Chromium] Some minor cleanup in the Chromium WebKit API There are missing WEBKIT_API decorations in WebNode.h and WebFormElement.h, which are used to annotate methods that should be exported from WebKit.dll. We should make WebNode::action() be a const method. We should utilize WebFrameImpl::fromFrame() to simplify code in WebNode::frame().
Attachments
v1 patch (3.19 KB, patch)
2009-11-17 22:45 PST, Darin Fisher (:fishd, Google) 		dimich: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2009-11-17 22:45:36 PST
Created attachment 43405 [details] v1 patch
Darin Fisher (:fishd, Google)
Comment 2 2009-11-18 13:49:28 PST
Landed as http://trac.webkit.org/changeset/51130
Note You need to log in before you can comment on or make changes to this bug.