Bug 31616

Summary:

[Chromium] Some minor cleanup in the Chromium WebKit API

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebKit API

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	dimich: review+

Description Darin Fisher (:fishd, Google) 2009-11-17 22:43:26 PST

[Chromium] Some minor cleanup in the Chromium WebKit API

There are missing WEBKIT_API decorations in WebNode.h and WebFormElement.h,
which are used to annotate methods that should be exported from WebKit.dll.

We should make WebNode::action() be a const method.

We should utilize WebFrameImpl::fromFrame() to simplify code in WebNode::frame().

Comment 1 Darin Fisher (:fishd, Google) 2009-11-17 22:45:36 PST

Created attachment 43405 [details]
v1 patch

Comment 2 Darin Fisher (:fishd, Google) 2009-11-18 13:49:28 PST

Landed as http://trac.webkit.org/changeset/51130