Bug 31604 – WebSocket server should write errors to a log file

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Mark Rowe (bdash)]

It’s currently difficult to work out what is going wrong if the WebSocket server fails to start.  If it wrote its errors to a log file in a similar fashion to what Apache does it would be easier to debug issues that only happen on inaccessible machines (eg, the build bots).

[Yuzo Fujishima]

Hi,

I've started addressing this upstream:
http://code.google.com/p/pywebsocket/issues/detail?id=24

After it is done upstream, I'll upload a WebKit patch to upgrade
the pywebsocket copy in WebKitTools to the latest.

Yuzo

[Yuzo Fujishima]

Created attachment 43898 [details]
Make pywebsocket log errors to a file

[Yuzo Fujishima]

Hi, reviewers,

Can you review this patch?

Yuzo

[David Levin]

Since this is perl, I'd prefer if someone else looked at it. (btw, Yuzo, it is a holiday in the US for Thursday and Friday so expect slower responses.)

[Eric Seidel (no email)]

Comment on attachment 43898 [details]
Make pywebsocket log errors to a file

Looks OK, but why are we coyping this code from elsewhere?  It should be abstracted into a sub routine.

I see this in the file already:

1380	    my $absTestResultsDirectory = File::Spec->rel2abs(glob $testResultsDirectory);
1381	    my $sslCertificate = "$testDirectory/http/conf/webkit-httpd.pem";
1382	
1383	    mkpath $absTestResultsDirectory;

[Yuzo Fujishima]

Created attachment 43999 [details]
Make pywebsocket log errors to a file

[Yuzo Fujishima]

Thank you for reviewing this.

Refactored by extracting a method.
Can you take another look?

Yuzo

[Yuzo Fujishima]

Created attachment 44002 [details]
Make pywebsocket log errors to a file

[Adam Barth]

style-queue ran check-webkit-style on attachment 44002 [details] without any errors.

[Alexey Proskuryakov]

Comment on attachment 44002 [details]
Make pywebsocket log errors to a file

r=me

I'll try to think of a better name for makeAbsTestResultsDirectory(), and will land manually. The current name is not great for several reasons:
- we don't like abbreviations in names;
- it's not an "absolute directory" that this method makes;
- nothing in the name suggests that there will be a return value.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/51550>. I also updated ChangeLog to be more useful to readers.