Bug 31594

Summary: bugzilla.py should have an Attachment object instead of passing around dictionaries
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue-

Eric Seidel (no email)
Reported 2009-11-17 11:53:15 PST
bugzilla.py should have an Attachment object instead of passing around dictionaries patch/attachment dictionaries were a great way to get started, but now we really should encapsulate more of the patch/attachment logic into a single class.
Attachments
Patch (56.37 KB, patch)
2010-01-12 03:22 PST, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-01-12 03:22:39 PST
Created attachment 46358 [details] Patch
Adam Barth
Comment 2 2010-01-12 03:51:24 PST
Comment on attachment 46358 [details] Patch Ok!!! Please address the verbal comments. I'm ready for a big explosion.
Eric Seidel (no email)
Comment 3 2010-01-12 04:04:10 PST
Committed r53133: <http://trac.webkit.org/changeset/53133>
Note You need to log in before you can comment on or make changes to this bug.