Bug 31594 - bugzilla.py should have an Attachment object instead of passing around dictionaries
Summary: bugzilla.py should have an Attachment object instead of passing around dictio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-17 11:53 PST by Eric Seidel (no email)
Modified: 2010-01-12 04:04 PST (History)
1 user (show)

See Also:


Attachments
Patch (56.37 KB, patch)
2010-01-12 03:22 PST, Eric Seidel (no email)
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-17 11:53:15 PST
bugzilla.py should have an Attachment object instead of passing around dictionaries

patch/attachment dictionaries were a great way to get started, but now we really should encapsulate more of the patch/attachment logic into a single class.
Comment 1 Eric Seidel (no email) 2010-01-12 03:22:39 PST
Created attachment 46358 [details]
Patch
Comment 2 Adam Barth 2010-01-12 03:51:24 PST
Comment on attachment 46358 [details]
Patch

Ok!!!  Please address the verbal comments.  I'm ready for a big explosion.
Comment 3 Eric Seidel (no email) 2010-01-12 04:04:10 PST
Committed r53133: <http://trac.webkit.org/changeset/53133>