|Summary:||Allow custom memory allocation control for the other part of platform directory in WebCore|
|Product:||WebKit||Reporter:||Zoltan Horvath <zoltan>|
|Component:||WebCore Misc.||Assignee:||Nobody <webkit-unassigned>|
|Version:||528+ (Nightly build)|
Description Zoltan Horvath 2009-11-17 07:02:19 PST
Comment 1 Zoltan Horvath 2009-11-17 07:04:33 PST
Created attachment 43363 [details] proposed patch
Comment 2 Eric Seidel (no email) 2009-11-18 13:45:20 PST
Comment on attachment 43363 [details] proposed patch I think this all looks fine to me except MediaPlayerPrivateInterface. MediaPlayerPrivateInterface is an ABC (Abastract Base Class), no? Does it make sense to mandate that the interface can't be copied? Maybe?
Comment 3 Zoltan Horvath 2009-11-18 15:23:40 PST
Yes, it is an ABC. It doesn't, but Darin said it'd be better to use Noncopyable where it's possible. This is the reason why I choose Noncopyable for this class.
Comment 4 Zoltan Horvath 2009-11-19 01:35:02 PST
Landed in 51179. http://trac.webkit.org/changeset/51179