Bug 31584

Summary: [Android] Add shared timer and sound utilities to platform/android
Product: WebKit Reporter: Andrei Popescu <andreip>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Add shared timer and sound utilities for Android.
dglazkov: review-
Add shared timer and sound utilities for Android v2 none

Andrei Popescu
Reported 2009-11-17 06:52:36 PST
Android is missing utilities for shared timers and sound.
Attachments
Add shared timer and sound utilities for Android. (5.29 KB, patch)
2009-11-17 06:57 PST, Andrei Popescu 		dglazkov: review-
DetailsFormatted DiffDiff
Add shared timer and sound utilities for Android v2 (deleted)
2009-11-17 08:59 PST, Andrei Popescu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrei Popescu
Comment 1 2009-11-17 06:57:33 PST
Created attachment 43360 [details] Add shared timer and sound utilities for Android.
Dimitri Glazkov (Google)
Comment 2 2009-11-17 08:38:37 PST
Comment on attachment 43360 [details] Add shared timer and sound utilities for Android. > +#define LOG_TAG "Timers" can this go just above "TimerClient" include? I'd like to keep config.h first, for consistency.
Andrei Popescu
Comment 3 2009-11-17 08:59:03 PST
Created attachment 43365 [details] Add shared timer and sound utilities for Android v2
Dimitri Glazkov (Google)
Comment 4 2009-11-17 09:01:36 PST
Comment on attachment 43365 [details] Add shared timer and sound utilities for Android v2 ok.
WebKit Commit Bot
Comment 5 2009-11-17 12:52:25 PST
Comment on attachment 43365 [details] Add shared timer and sound utilities for Android v2 Rejecting patch 43365 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11628 test cases. http/tests/xmlhttprequest/workers/close.html -> crashed Exiting early after 1 failures. 9314 tests run. 363.98s total testing time 9313 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 6 2009-11-17 13:05:21 PST
Comment on attachment 43365 [details] Add shared timer and sound utilities for Android v2 Sigh. Bug 31461.
WebKit Commit Bot
Comment 7 2009-11-18 14:49:44 PST
Comment on attachment 43365 [details] Add shared timer and sound utilities for Android v2 Clearing flags on attachment: 43365 Committed r51140: <http://trac.webkit.org/changeset/51140>
WebKit Commit Bot
Comment 8 2009-11-18 14:49:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.