| Summary: | [Android] Add shared timer and sound utilities to platform/android | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andrei Popescu <andreip> | ||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | android-webkit-unforking, commit-queue | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | Other | ||||||||
| Attachments: |
|
||||||||
|
Description
Andrei Popescu
2009-11-17 06:52:36 PST
Created attachment 43360 [details]
Add shared timer and sound utilities for Android.
Comment on attachment 43360 [details] Add shared timer and sound utilities for Android. > +#define LOG_TAG "Timers" can this go just above "TimerClient" include? I'd like to keep config.h first, for consistency. Created attachment 43365 [details]
Add shared timer and sound utilities for Android v2
Comment on attachment 43365 [details]
Add shared timer and sound utilities for Android v2
ok.
Comment on attachment 43365 [details]
Add shared timer and sound utilities for Android v2
Rejecting patch 43365 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11628 test cases.
http/tests/xmlhttprequest/workers/close.html -> crashed
Exiting early after 1 failures. 9314 tests run.
363.98s total testing time
9313 test cases (99%) succeeded
1 test case (<1%) crashed
5 test cases (<1%) had stderr output
Comment on attachment 43365 [details] Add shared timer and sound utilities for Android v2 Sigh. Bug 31461. Comment on attachment 43365 [details] Add shared timer and sound utilities for Android v2 Clearing flags on attachment: 43365 Committed r51140: <http://trac.webkit.org/changeset/51140> All reviewed patches have been landed. Closing bug. |