Bug 31584 - [Android] Add shared timer and sound utilities to platform/android
Summary: [Android] Add shared timer and sound utilities to platform/android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-17 06:52 PST by Andrei Popescu
Modified: 2009-11-18 14:49 PST (History)
2 users (show)

See Also:

Attachments
Add shared timer and sound utilities for Android. (5.29 KB, patch)
2009-11-17 06:57 PST, Andrei Popescu 		dglazkov: review-
Details | Formatted Diff | Diff
Add shared timer and sound utilities for Android v2 (deleted)
2009-11-17 08:59 PST, Andrei Popescu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Popescu 2009-11-17 06:52:36 PST 
Android is missing utilities for shared timers and sound.
Comment 1 Andrei Popescu 2009-11-17 06:57:33 PST 
Created attachment 43360 [details]
Add shared timer and sound utilities for Android.
Comment 2 Dimitri Glazkov (Google) 2009-11-17 08:38:37 PST 
Comment on attachment 43360 [details]
Add shared timer and sound utilities for Android.

> +#define LOG_TAG "Timers"

can this go just above "TimerClient" include? I'd like to keep config.h first, for consistency.
Comment 3 Andrei Popescu 2009-11-17 08:59:03 PST 
Created attachment 43365 [details]
Add shared timer and sound utilities for Android v2
Comment 4 Dimitri Glazkov (Google) 2009-11-17 09:01:36 PST 
Comment on attachment 43365 [details]
Add shared timer and sound utilities for Android v2

ok.
Comment 5 WebKit Commit Bot 2009-11-17 12:52:25 PST 
Comment on attachment 43365 [details]
Add shared timer and sound utilities for Android v2

Rejecting patch 43365 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11628 test cases.
http/tests/xmlhttprequest/workers/close.html -> crashed

Exiting early after 1 failures. 9314 tests run.
363.98s total testing time

9313 test cases (99%) succeeded
1 test case (<1%) crashed
5 test cases (<1%) had stderr output
Comment 6 Eric Seidel (no email) 2009-11-17 13:05:21 PST 
Comment on attachment 43365 [details]
Add shared timer and sound utilities for Android v2

Sigh.  Bug 31461.
Comment 7 WebKit Commit Bot 2009-11-18 14:49:44 PST 
Comment on attachment 43365 [details]
Add shared timer and sound utilities for Android v2

Clearing flags on attachment: 43365

Committed r51140: <http://trac.webkit.org/changeset/51140>
Comment 8 WebKit Commit Bot 2009-11-18 14:49:49 PST 
All reviewed patches have been landed.  Closing bug.