Summary: | Fix WebKit build when JAVASCRIPT_DEBUGGER is disabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dglazkov, dimich, eric, mnaganov, oliver | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Laszlo Gombos
2009-11-16 22:01:40 PST
Created attachment 43377 [details]
Proposed fix
I tried to make 'console.profile()' and 'console.profileEnd()' declarations platform-dependent, but for some reason this doesn't work. So I took another route and made their implementations empty in the case when there is no debugger.
Laszlo, can you try your debuggerless Qt build with this patch, please?
I can confirm that the proposed patch builds for JSC + ENABLE_JAVASCRIPT_DEBUGGER=0 case (tested with build-webkit --qt --minimal) > I tried to make 'console.profile()' and 'console.profileEnd()' declarations
> platform-dependent, but for some reason this doesn't work. So I took another
> route and made their implementations empty in the case when there is no
> debugger.
It seems that defined(V8_BINDING) && V8_BINDING is the way used in IDL files to check if the bindings are generated for V8. It might be a cleaner way to do this.
Created attachment 43418 [details]
an easier way
Thanks, Dimich! That's really an easier way, and it works with Chromium.
Laszlo, can I ask you to test this patch, please? If it works for you, I'll find someone to review and submit it.
Comment on attachment 43418 [details]
an easier way
I don't understand why the chromium build doesn't define ENABLE_JAVASCRIPT_DEBUGGER. Probably because ENABLE_JAVASCRIPT_DEBUGGER depends on JSC? If that's the case then we really should come up with a define for the debugger which would not depend on JSC.
(I'm not sure who the JSC debugger expert is these days, but ccing Oliver so that someone in JSC land sees this go by.) Comment on attachment 43418 [details] an easier way Clearing flags on attachment: 43418 Committed r51153: <http://trac.webkit.org/changeset/51153> All reviewed patches have been landed. Closing bug. Thanks ! (In reply to comment #5) > (From update of attachment 43418 [details]) > I don't understand why the chromium build doesn't define > ENABLE_JAVASCRIPT_DEBUGGER. Probably because ENABLE_JAVASCRIPT_DEBUGGER > depends on JSC? If that's the case then we really should come up with a define > for the debugger which would not depend on JSC. Yes, currently the code under ENABLE_JAVASCRIPT_DEBUGGER defines is tied directly to JSC, so it won't event compile in Chromium. |