Bug 31558

Summary:	Missing guards in inspector headers files
Product:	WebKit	Reporter:	Nicolas Roard <nicolas>
Component:	Web Inspector	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED INVALID
Severity:	Minor	CC:	android-webkit-unforking, bburg, jchaffraix, joepeck, timothy, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	528+ (Nightly build)
Hardware:	All
OS:	All

Nicolas Roard

Reported 2009-11-16 08:14:46 PST

InspectorBackend, InspectorClient, InspectorController, InspectorDOMAgent, InspectorDOMStorageResource, InspectorDatabaseResource, InspectorFrontend, InspectorResource do not have guards and are compiled unecessary when INSPECTOR is not defined. I will upload a patch for those guards as soon as the patch for bug 31504 lands...

Attachments
Add attachment proposed patch, testcase, etc.

Blaze Burg

Comment 1 2014-01-12 16:17:06 PST

There are still some missing guards, but the list provided is out of date.

Radar WebKit Bug Importer

Comment 2 2014-01-12 16:17:23 PST

<rdar://problem/15801502>

Joseph Pecoraro

Comment 3 2016-04-20 12:14:47 PDT

ENABLE(INSPECTOR) no longer exists.

Note You need to log in before you can comment on or make changes to this bug.