Bug 31534

Summary: WorkQueue is the only place that should know about special exit codes
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 31535    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Eric Seidel (no email)
Reported 2009-11-16 01:44:14 PST
WorkQueue is the only place that should know about special exit codes When a child process handles an error but still needs to exit early, we use a special error code. This lets the child process no exit(0) (normal exit) which would be mildly confusing. Lets move this special handling all into one file (workqueue.py) so that the logic and comments are all in one place.
Attachments
Patch (3.65 KB, patch)
2009-11-16 01:45 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (9.10 KB, patch)
2009-11-16 02:29 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-11-16 01:45:51 PST
Created attachment 43278 [details] Patch
Adam Barth
Comment 2 2009-11-16 01:47:31 PST
Comment on attachment 43278 [details] Patch cls.handled_error_code and unit test!
Eric Seidel (no email)
Comment 3 2009-11-16 02:29:47 PST
Created attachment 43284 [details] Patch
Adam Barth
Comment 4 2009-11-16 02:36:39 PST
Comment on attachment 43284 [details] Patch Excellent!
Eric Seidel (no email)
Comment 5 2009-11-16 03:04:24 PST
Comment on attachment 43284 [details] Patch Clearing flags on attachment: 43284 Committed r51024: <http://trac.webkit.org/changeset/51024>
Eric Seidel (no email)
Comment 6 2009-11-16 03:04:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.