Bug 31534

Summary: WorkQueue is the only place that should know about special exit codes
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 31535    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Eric Seidel (no email) 2009-11-16 01:44:14 PST 
WorkQueue is the only place that should know about special exit codes

When a child process handles an error but still needs to exit early, we use a special error code.  This lets the child process no exit(0) (normal exit) which would be mildly confusing.

Lets move this special handling all into one file (workqueue.py) so that the logic and comments are all in one place.
Comment 1 Eric Seidel (no email) 2009-11-16 01:45:51 PST 
Created attachment 43278 [details]
Patch
Comment 2 Adam Barth 2009-11-16 01:47:31 PST 
Comment on attachment 43278 [details]
Patch

cls.handled_error_code

and unit test!
Comment 3 Eric Seidel (no email) 2009-11-16 02:29:47 PST 
Created attachment 43284 [details]
Patch
Comment 4 Adam Barth 2009-11-16 02:36:39 PST 
Comment on attachment 43284 [details]
Patch

Excellent!
Comment 5 Eric Seidel (no email) 2009-11-16 03:04:24 PST 
Comment on attachment 43284 [details]
Patch

Clearing flags on attachment: 43284

Committed r51024: <http://trac.webkit.org/changeset/51024>
Comment 6 Eric Seidel (no email) 2009-11-16 03:04:31 PST 
All reviewed patches have been landed.  Closing bug.