Bug 315248
| Summary: | [CMake] Forward --cmake from run-minibrowser/run-swiftbrowser to underlying perl scripts | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | Tools / Tests | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
Follow-up to 313522@main, which added --cmake to configuration_options()
but didn't thread it through Port.run_minibrowser() / Port.run_swiftbrowser().
As a result, `run-minibrowser --debug --cmake` accepted the flag at the
Python layer but never passed it to old-run-minibrowser, so webkitdirs.pm
fell back to the Xcode build tree and the launch failed to find the
CMake-built MiniBrowser.
Append --cmake to the args passed to old-run-minibrowser and
run-swiftbrowser-perl-wrapper when the option is set, matching how
--<platform> and --<configuration> are already forwarded.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/177574770>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/65352
EWS
Committed 313629@main (62cd2f059024): <https://commits.webkit.org/313629@main>
Reviewed commits have been landed. Closing PR #65352 and removing active labels.