Bug 315067
| Summary: | [CMake] Compile per-test plug-in classes into TestWebKitAPI.wkbundle | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | CMake | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
I added the per-test plug-in classes from the Xcode WebProcessPlugIn target's membershipExceptions list. Five files are dual-membership with TestWebKit; since WEBKIT_COMPUTE_SOURCES marks their originals HEADER_FILE_ONLY, build them here via generated #include shims.
Extend the include path with Tests/WebKit/WKWebView and WebCore_PRIVATE_FRAMEWORK_HEADERS_DIR.
I also added the missing direct imports to ClearWrappersNavigatePlugIn.mm (<wtf/RetainPtr.h>) and ContentFilteringPlugIn.mm (<WebCore/PlatformExportMacros.h>); both were relying on the prefix-header / BUILDING_TestWebKit config path that the bundle target doesn't go through.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/177396182>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/65157
EWS
Committed 313519@main (e3b3680f8792): <https://commits.webkit.org/313519@main>
Reviewed commits have been landed. Closing PR #65157 and removing active labels.