Bug 31506

Summary: [GTK] Style cleanup for GOwnPtr
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Style cleanups for GOwnPtr none

Martin Robinson
Reported 2009-11-13 23:32:11 PST
- Code inside the namespace should not be indented. - glib includes should be replaced by foward declarations. - The reinterpret_cast to a void* in freeOwnedGPtr is unecessary.
Attachments
Style cleanups for GOwnPtr (7.12 KB, patch)
2009-11-13 23:40 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2009-11-13 23:40:41 PST
Created attachment 43223 [details] Style cleanups for GOwnPtr Attached a patch for this issue. I was inspired to do this by Alp Toker's request in https://bugs.webkit.org/show_bug.cgi?id=21599 .
Adam Barth
Comment 2 2009-11-14 23:20:12 PST
Comment on attachment 43223 [details] Style cleanups for GOwnPtr The diff is slightly hard to read, but this looks correct as far as I can tell.
WebKit Commit Bot
Comment 3 2009-11-17 12:38:49 PST
Comment on attachment 43223 [details] Style cleanups for GOwnPtr Clearing flags on attachment: 43223 Committed r51086: <http://trac.webkit.org/changeset/51086>
WebKit Commit Bot
Comment 4 2009-11-17 12:38:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.