Bug 315050
| Summary: | [CMake][Mac] mac-tsan: set USE_SYSTEM_MALLOC=ON and guard TSan bindir against uninstrumented reconfigure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Lewis <simon.lewis> |
| Component: | CMake | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | macOS 26 | ||
Simon Lewis
Two fixes for the mac-tsan preset:
1. Set USE_SYSTEM_MALLOC=ON. e05f64d91da made bmalloc force BUSE_SYSTEM_MALLOC=1 under __has_feature(thread_sanitizer) (BPlatform.h), so BUSE_TZONE=0. But WTF's PlatformUse.h has no matching TSan branch, so USE_TZONE_MALLOC stays 1, and TZoneMalloc.h #errors "TZones enabled in WTF, but not enabled in bmalloc". Setting USE_SYSTEM_MALLOC at the preset level keeps WTF and bmalloc in agreement.
2. Extend the OptionsMac.cmake bindir-name guard to TSan. When a ninja-triggered RERUN_CMAKE wipes CMakeCache.txt, the reconfigure runs without --preset and silently produces an uninstrumented build. The ASan tree already FATAL_ERRORs on this; do the same for TSan.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/177376705>
EWS
Committed 313486@main (6acf180f923e): <https://commits.webkit.org/313486@main>
Reviewed commits have been landed. Closing PR #65135 and removing active labels.