Bug 31505

Summary:

[GTK] Tab key does not cycle through elements by default

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch for this issue	gustavo: review-
Ensure that tab-key-cycles-through-elements is true by default	gustavo: review+, gustavo: commit-queue-
Properly localize tab-key-cycles-through-elements documentation strings	none
Properly localize documentation strings (with Changelog)	gustavo: review+, gustavo: commit-queue-

Martin Robinson

Reported 2009-11-13 21:29:27 PST

This seems to be caused by caused by r50642 ( http://trac.webkit.org/changeset/50642 ).

Attachments
Patch for this issue (5.18 KB, patch) 2009-11-13 22:35 PST, Martin Robinson	gustavo: review-	Details Formatted Diff Diff
Ensure that tab-key-cycles-through-elements is true by default (4.76 KB, patch) 2009-11-17 11:57 PST, Martin Robinson	gustavo: review+ gustavo: commit-queue-	Details Formatted Diff Diff
Properly localize tab-key-cycles-through-elements documentation strings (1.45 KB, patch) 2009-11-17 11:57 PST, Martin Robinson	no flags	Details Formatted Diff Diff
Properly localize documentation strings (with Changelog) (2.34 KB, patch) 2009-11-17 12:43 PST, Martin Robinson	gustavo: review+ gustavo: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2009-11-13 22:35:55 PST

Created attachment 43222 [details] Patch for this issue This problem seems to be the result of a bad merge. I've attached a patch correcting the merge and extending the original insert-tab test to cover this case.

Gustavo Noronha (kov)

Comment 2 2009-11-17 10:20:39 PST

Comment on attachment 43222 [details] Patch for this issue > + el.focus(); > + if (window.eventSender) { > + eventSender.keyDown("\t"); > + } Braces. > if (window.layoutTestController) { > layoutTestController.dumpAsText(); > - // Set this preference so the tab key will actually insert a tab character- like in Mail. > + } More braces? =) > + if (window.layoutTestController) { > layoutTestController.setTabKeyCyclesThroughElements(false); > } Ditto. There are some others. Can you split the test from the translatable strings/param flags?

Martin Robinson

Comment 3 2009-11-17 11:57:15 PST

Created attachment 43374 [details] Ensure that tab-key-cycles-through-elements is true by default Thanks for the review. I'm attaching corrected patches now.

Martin Robinson

Comment 4 2009-11-17 11:57:54 PST

Created attachment 43375 [details] Properly localize tab-key-cycles-through-elements documentation strings

Martin Robinson

Comment 5 2009-11-17 12:43:04 PST

Created attachment 43378 [details] Properly localize documentation strings (with Changelog) Forgot the Changelog on the last patch; attaching a corrected patch now.

Gustavo Noronha (kov)

Comment 6 2009-11-18 04:40:42 PST

Comment on attachment 43374 [details] Ensure that tab-key-cycles-through-elements is true by default looks good

Gustavo Noronha (kov)

Comment 7 2009-11-18 04:41:19 PST

Comment on attachment 43378 [details] Properly localize documentation strings (with Changelog) This one as well.

Gustavo Noronha (kov)

Comment 8 2009-11-18 04:55:21 PST

Comment on attachment 43374 [details] Ensure that tab-key-cycles-through-elements is true by default I will land manually, since the bot is down.

Gustavo Noronha (kov)

Comment 9 2009-11-18 04:55:28 PST

Comment on attachment 43378 [details] Properly localize documentation strings (with Changelog) I will land manually, since the bot is down.

Gustavo Noronha (kov)

Comment 10 2009-11-18 05:21:00 PST

Landed as r51108, and r51109.

Note You need to log in before you can comment on or make changes to this bug.