Summary: | [GTK] Tab key does not cycle through elements by default | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | gustavo | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Linux | ||||||||||||
Attachments: |
|
Description
Martin Robinson
2009-11-13 21:29:27 PST
Created attachment 43222 [details]
Patch for this issue
This problem seems to be the result of a bad merge. I've attached a patch correcting the merge and extending the original insert-tab test to cover this case.
Comment on attachment 43222 [details] Patch for this issue > + el.focus(); > + if (window.eventSender) { > + eventSender.keyDown("\t"); > + } Braces. > if (window.layoutTestController) { > layoutTestController.dumpAsText(); > - // Set this preference so the tab key will actually insert a tab character- like in Mail. > + } More braces? =) > + if (window.layoutTestController) { > layoutTestController.setTabKeyCyclesThroughElements(false); > } Ditto. There are some others. Can you split the test from the translatable strings/param flags? Created attachment 43374 [details]
Ensure that tab-key-cycles-through-elements is true by default
Thanks for the review. I'm attaching corrected patches now.
Created attachment 43375 [details]
Properly localize tab-key-cycles-through-elements documentation strings
Created attachment 43378 [details]
Properly localize documentation strings (with Changelog)
Forgot the Changelog on the last patch; attaching a corrected patch now.
Comment on attachment 43374 [details]
Ensure that tab-key-cycles-through-elements is true by default
looks good
Comment on attachment 43378 [details]
Properly localize documentation strings (with Changelog)
This one as well.
Comment on attachment 43374 [details]
Ensure that tab-key-cycles-through-elements is true by default
I will land manually, since the bot is down.
Comment on attachment 43378 [details]
Properly localize documentation strings (with Changelog)
I will land manually, since the bot is down.
|