Bug 31491

Summary: DOMHTMLOptionElement is missing some implementation
Product: WebKit Reporter: Jon Honeycutt <jhoneycutt>
Component: WebKit Misc.Assignee: Jon Honeycutt <jhoneycutt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch mitz: review+, jhoneycutt: commit-queue-

Jon Honeycutt
Reported 2009-11-13 14:04:44 PST
DOMHTMLOptionElement::text() and DOMHTMLOptionElement::label() are stubs.
Attachments
patch (2.84 KB, patch)
2009-11-13 14:16 PST, Jon Honeycutt 		mitz: review+
jhoneycutt: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jon Honeycutt
Comment 1 2009-11-13 14:16:37 PST
Created attachment 43201 [details] patch
mitz
Comment 2 2009-11-13 15:06:26 PST
Comment on attachment 43201 [details] patch > + ASSERT(m_element && m_element->hasTagName(optionTag)); Please split into two assertions. > + ASSERT(m_element && m_element->hasTagName(optionTag)); Ditto.
Jon Honeycutt
Comment 3 2009-11-17 15:40:32 PST
I made Dan's change. Landed in r51093.
Note You need to log in before you can comment on or make changes to this bug.