Bug 31491

Summary: DOMHTMLOptionElement is missing some implementation
Product: WebKit Reporter: Jon Honeycutt <jhoneycutt>
Component: WebKit Misc.Assignee: Jon Honeycutt <jhoneycutt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch mitz: review+, jhoneycutt: commit-queue-

Description Jon Honeycutt 2009-11-13 14:04:44 PST
DOMHTMLOptionElement::text() and DOMHTMLOptionElement::label() are stubs.
Comment 1 Jon Honeycutt 2009-11-13 14:16:37 PST
Created attachment 43201 [details]
patch
Comment 2 mitz 2009-11-13 15:06:26 PST
Comment on attachment 43201 [details]
patch

> +    ASSERT(m_element && m_element->hasTagName(optionTag));

Please split into two assertions.

> +    ASSERT(m_element && m_element->hasTagName(optionTag));

Ditto.
Comment 3 Jon Honeycutt 2009-11-17 15:40:32 PST
I made Dan's change.

Landed in r51093.