Bug 31479

Summary:

Make websocket tests work on Windows

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, aroben, ukai, yuzo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Disable wss until all platforms support pyOpenSSL	none
Disable wss until all platforms support pyOpenSSL	none
Fix WebSockets tests on Windows	ap: review+

Alexey Proskuryakov

Reported 2009-11-13 11:28:20 PST

The server won't start on BuildBot: <http://build.webkit.org/builders/Windows%20Debug%20%28Tests%29/builds/6566/steps/layout-test/logs/stdio>. I couldn't try this locally, as DRT fails to build for me for some reason.

Attachments
Disable wss until all platforms support pyOpenSSL (4.15 KB, patch) 2009-11-15 22:03 PST, Yuzo Fujishima	no flags	Details Formatted Diff Diff
Disable wss until all platforms support pyOpenSSL (4.15 KB, patch) 2009-11-15 22:12 PST, Yuzo Fujishima	no flags	Details Formatted Diff Diff
Fix WebSockets tests on Windows (1.33 KB, patch) 2009-12-01 12:56 PST, Adam Roben (:aroben)	ap: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yuzo Fujishima

Comment 1 2009-11-15 22:03:47 PST

Created attachment 43263 [details] Disable wss until all platforms support pyOpenSSL

Yuzo Fujishima

Comment 2 2009-11-15 22:07:41 PST

Please review the patch attached. The Web Socket server cannot be run for wss on Windows because pyOpenSSL is not available there yet. I chose to disable wss because there are currently no tests for it. Yuzo

Yuzo Fujishima

Comment 3 2009-11-15 22:12:22 PST

Created attachment 43264 [details] Disable wss until all platforms support pyOpenSSL

Alexey Proskuryakov

Comment 4 2009-11-16 10:10:19 PST

Comment on attachment 43264 [details] Disable wss until all platforms support pyOpenSSL I tested that the patch helps on Mac OS X 10.4 (Tiger). I cannot easily test on Windows. We don't usually keep commented out code - if necessary, it can be restored from Subversion history. Do you have a plan how to enable it soon? r=me, as we need to get the tests running, but please consider my comment.

Alexey Proskuryakov

Comment 5 2009-11-16 10:11:08 PST

*** Bug 31501 has been marked as a duplicate of this bug. ***

Alexey Proskuryakov

Comment 6 2009-11-16 10:40:43 PST

Committed revision 51041, re-enabling tests at the same time. Commit queue doesn't work now.

Alexey Proskuryakov

Comment 7 2009-11-16 15:19:19 PST

Still times out on buildbot: <http://build.webkit.org/builders/Windows%20Release%20%28Tests%29/builds/6228/steps/layout-test/logs/stdio>.

Alexey Proskuryakov

Comment 8 2009-12-01 12:55:30 PST

It looks like the server starts now, but tests still don't work, because they are broken by previous scripts (from userscripts directory). Adam Roben is looking into the userscripts problem, and once that's fixed, we might be all set.

Adam Roben (:aroben)

Comment 9 2009-12-01 12:56:36 PST

Created attachment 44095 [details] Fix WebSockets tests on Windows

Alexey Proskuryakov

Comment 10 2009-12-01 12:57:34 PST

Comment on attachment 44095 [details] Fix WebSockets tests on Windows r=me

Adam Roben (:aroben)

Comment 11 2009-12-01 12:59:42 PST

Committed r51554: <http://trac.webkit.org/changeset/51554>

Note You need to log in before you can comment on or make changes to this bug.