Summary: | Make websocket tests work on Windows | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, aroben, ukai, yuzo | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2009-11-13 11:28:20 PST
Created attachment 43263 [details]
Disable wss until all platforms support pyOpenSSL
Please review the patch attached. The Web Socket server cannot be run for wss on Windows because pyOpenSSL is not available there yet. I chose to disable wss because there are currently no tests for it. Yuzo Created attachment 43264 [details]
Disable wss until all platforms support pyOpenSSL
Comment on attachment 43264 [details]
Disable wss until all platforms support pyOpenSSL
I tested that the patch helps on Mac OS X 10.4 (Tiger). I cannot easily test on Windows.
We don't usually keep commented out code - if necessary, it can be restored from Subversion history. Do you have a plan how to enable it soon?
r=me, as we need to get the tests running, but please consider my comment.
*** Bug 31501 has been marked as a duplicate of this bug. *** Committed revision 51041, re-enabling tests at the same time. Commit queue doesn't work now. Still times out on buildbot: <http://build.webkit.org/builders/Windows%20Release%20%28Tests%29/builds/6228/steps/layout-test/logs/stdio>. It looks like the server starts now, but tests still don't work, because they are broken by previous scripts (from userscripts directory). Adam Roben is looking into the userscripts problem, and once that's fixed, we might be all set. Created attachment 44095 [details]
Fix WebSockets tests on Windows
Comment on attachment 44095 [details]
Fix WebSockets tests on Windows
r=me
Committed r51554: <http://trac.webkit.org/changeset/51554> |