Summary: | [V8] Fix V8Bindings link error in Linux+GCC 4.4 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jens Alfke <jens> | ||||
Component: | WebCore Misc. | Assignee: | Jens Alfke <jens> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | eric | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Jens Alfke
2009-11-13 09:59:00 PST
Created attachment 43168 [details]
patch
Here's the patch. Waiting to set 'review?' flag till after I make sure it builds on Win/Linux.
Comment on attachment 43168 [details]
patch
OK, this has passed the trybots, so requesting a review.
Comment on attachment 43168 [details]
patch
Wrong mime type on the attachment. :) Tools like "bugzilla-tool post-diff" will take care of all the silly check-boxes and mime types for you if you like.
This looks sane to me, but I'm really not enough of a c++ expert to comment here. Comment on attachment 43168 [details]
patch
I am not teh expert, but I believe jens! :)
Committed revision 50967. |