Bug 31471
| Summary: | Web Inspector: Refactor timeline tests so that they do not require reload | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> |
| Component: | Web Inspector (Deprecated) | Assignee: | Eric Ayers <zundel> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bweinstein, joepeck, rik, timothy, zundel |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 31472 | ||
Pavel Feldman
I am about to modify testing framework so that inspector is shown by the DRT rather than test itself. It'll make us faster, more robust and allow more reliable cleanup after the test. Timeline tests are the only ones that do not work with the new setup. Two ways of fixing:
1) After installing custom handler for addRecord, do something on page in order to get some timeline records
2) Do not install custom handler, go through the WebInspector.panels.timeline._items array instead. Note that it contains 'formatted' records, not the original ones that came from the backend. However, it is easy to modify the TimelinePanel and make formatted record point to the original one. I like (2) more.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Pavel Feldman
This has been landed in patches from other bugs.