Bug 314676
| Summary: | [check-webkit-style] Flag deprecated js-test-pre/post/post-async.js includes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | Tools / Tests | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
New tests should use LayoutTests/resources/js-test.js, which combines
the functionality of the old trio. For async tests, set
window.jsTestIsAsync = true and call finishJSTest() when done.
- Adds DeprecatedJSTestIncludesChecker, composed into TextChecker, with
unit tests. Category build/deprecated/js-test-helpers, severity 5.
- Adds a // DEPRECATED: banner to the six resource files pointing
authors at js-test.js. The LayoutTests/resources/ and
http/tests/resources/ pairs remain byte-identical as JSTestChecker
requires.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176924986>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/64791
EWS
Committed 313204@main (ea89893f4a43): <https://commits.webkit.org/313204@main>
Reviewed commits have been landed. Closing PR #64791 and removing active labels.