Summary: | svn-apply may not handle git patches created by bugzilla-tool | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinichiro Hamaji <hamaji> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 31458 | ||||||||
Attachments: |
|
Description
Shinichiro Hamaji
2009-11-12 23:21:47 PST
Created attachment 43138 [details]
Patch v1
Comment on attachment 43138 [details]
Patch v1
The rstripping was added for convenience when dealing with output from commands like svn info, where it's just a single line of output and you don't actually want the trailing \n. We can easily remove the rstrip() and fix all callers to deal with the added newline if that's better?
Created attachment 43213 [details]
Patch v2
I agree run_command should return non-rstripped values if there are no critical reasons. I updated my patch. Comment on attachment 43213 [details]
Patch v2
Fantastic!
Thanks for the review! Closing this bug. |