Bug 31452

Summary: Fix worker-timeout.html layout test that fails in Chromium harness.
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: Tools / TestsAssignee: Dmitry Titov <dimich>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch. darin: review+, dimich: commit-queue-

Description Dmitry Titov 2009-11-12 19:09:13 PST 
In DRT, the layoutTestController.notifyDone() captures the output immediately. In Chromium, the test_shell does the same. However, some layout tests (those that require multiprocess config) are running in ui_test Chromium harness that runs the full Chromium browser and uses different implementation of layoutTestController. In that one, the notifyDone() runs message loop for a while before capturing the output. This causes worker-timeout test to squeeze more lines into the log then expected. This is Chromium bug http://crbug.com/25548

The test keeps active interval firing while terminating, to verify that this doesn't cause a crash (it did at some point). So lets keep the interval firing but stop logging once notifyDone() is called. Patch forthcoming.
Comment 1 Dmitry Titov 2009-11-12 19:22:21 PST 
Created attachment 43128 [details]
Proposed patch.
Comment 2 Dmitry Titov 2009-11-13 10:08:13 PST 
Landed: http://trac.webkit.org/changeset/50950